Alexey Serbin has posted comments on this change.

Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG
Commit Message:

PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get 
through a
            : full run of "mvn verify" locally, so I have confidence that this 
can work.
            : But I'd like to solicit feedback on the general approach before 
spending
            : more time applying spit and polish.
> I went back and forth on this.
Would it be possible to use JSON format as an internal format  of the tool, 
while translating the command-line arguments into a JSON document which would 
be consumed internally?  Basically, it's about a shim layer which translates 
the command-line arguments into a JSON representation.

Vice versa: it could be the same for the output.  As for the output, there are 
libraries like libxo to handle that in a uniform way:
  https://github.com/Juniper/libxo


-- 
To view, visit http://gerrit.cloudera.org:8080/7853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to