Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 )
Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG@47 PS2, Line 47: : WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on > I'm on board with protobuf for schema / json as encoded format as well. OK, PS3 changes the interface to use a protobuf-based schema with an optional JSON serialization. The former provides more type safety for clients who are willing to eat the protobuf dependency and the latter for those who aren't. -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-Change-Number: 7853 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:13:20 +0000 Gerrit-HasComments: Yes
