Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 )
Change subject: [docs] Add basic advice on setting block cache size ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11420/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11420/1//COMMIT_MSG@11 PS1, Line 11: are so : workload dependent (e.g. consider a workload doing full table scans vs. : one mostly re-scanning a small rang > In the commit message, in the docs, or you are just letting me know? (Thank I was just letting you know. To the extent that it affects this patch...you could argue that a well-written full table scan will NOT cache blocks and thus have no effect on the block cache. But that's not a given, and I don't even know if Impala uses that API. http://gerrit.cloudera.org:8080/#/c/11420/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11420/2//COMMIT_MSG@10 PS2, Line 10: the performance of the block cache size This still doesn't make sense; what is the "performance of the block cache size"? Did you mean "the performance of the block cache"? -- To view, visit http://gerrit.cloudera.org:8080/11420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7411c38b6fcc8694509ec89c32e2fe74e6c0db Gerrit-Change-Number: 11420 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 13 Sep 2018 18:47:07 +0000 Gerrit-HasComments: Yes
