Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11420 )

Change subject: [docs] Add basic advice on setting block cache size
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@557
PS1, Line 557: metrics
> Oops. Tangentially, why comment as a question if you know the text is wrong
I was confused about whether there was some other endpoint I didn't know about 
:)


http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@602
PS1, Line 602: Kudu expected to read from cache but which weren't found in the 
cache. If a
> Looking at how the metrics behave on my local cluster, loading a block fres
Ah, I misinterpreted the above definition of `block_cache_misses_caching` as 
"the number of blocks Kudu expected to read from cache because it put it there, 
but which weren't found" i.e. those that were evicted from the cache that we 
maybe shouldn't have evicted.

Maybe reword the above definition to just "the number of blocks that Kudu tried 
to read from the cache but weren't found" or something?


http://gerrit.cloudera.org:8080/#/c/11420/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11420/2/docs/troubleshooting.adoc@596
PS2, Line 596:  on a tablet server
Doesn't the same guidance apply to the masters as well? Though I guess it's not 
as important given how little activity there is on the masters.



--
To view, visit http://gerrit.cloudera.org:8080/11420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7411c38b6fcc8694509ec89c32e2fe74e6c0db
Gerrit-Change-Number: 11420
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 18:34:12 +0000
Gerrit-HasComments: Yes

Reply via email to