Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11420 )

Change subject: [docs] Add basic advice on setting block cache size
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11420/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11420/1//COMMIT_MSG@11
PS1, Line 11: are so
            : workload dependent (e.g. consider a workload doing full table 
scans vs.
            : one mostly re-scanning a small rang
> I was just letting you know. To the extent that it affects this patch...you
(thumbsup)


http://gerrit.cloudera.org:8080/#/c/11420/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11420/2//COMMIT_MSG@10
PS2, Line 10: the performance of the block cache size
> This still doesn't make sense; what is the "performance of the block cache
Oops.


http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@557
PS1, Line 557: metrics
> I was confused about whether there was some other endpoint I didn't know ab
(thumbsup)


http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@602
PS1, Line 602: Kudu expected to read from cache but which weren't found in the 
cache. If a
> Ah, I misinterpreted the above definition of `block_cache_misses_caching` a
:/ That's the correct interpretation...we just expect to find every block in 
the cache always unless the cache is off, I think :). Maybe that would change, 
but phrased this way the docs are relatively future-proofed, even if the part 
about checking eviction vs insertion numbers becomes redundant.


http://gerrit.cloudera.org:8080/#/c/11420/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11420/2/docs/troubleshooting.adoc@596
PS2, Line 596:  on a tablet server
> Doesn't the same guidance apply to the masters as well? Though I guess it's
It sure does, but if you are struggling with cache performance on your masters 
you are in a realm of Kudu scalability where we don't know how to help you.



--
To view, visit http://gerrit.cloudera.org:8080/11420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7411c38b6fcc8694509ec89c32e2fe74e6c0db
Gerrit-Change-Number: 11420
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 18:56:35 +0000
Gerrit-HasComments: Yes

Reply via email to