Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12776 )
Change subject: [util] separate generalized CacheMetrics ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG@10 PS2, Line 10: using to use http://gerrit.cloudera.org:8080/#/c/12776/2//COMMIT_MSG@10 PS2, Line 10: The LRUCache now uses : LRUCacheMetrics which has some specifics attributed to LRUCache itself. Not seeing LRUCacheMetrics here; was this from a previous approach? http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc@465 PS2, Line 465: unique_ptr<BlockCacheMetrics> metrics(new BlockCacheMetrics(entity)); Not your fault, but this change highlights that the metrics used for FileCache were bogus. Do the "block cache" metrics actually report the sum of both BlockCache and FileCache usage? If so, that's pretty bad and we should fix it. If you can confirm that this is the case, please file a JIRA. -- To view, visit http://gerrit.cloudera.org:8080/12776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic77b937e23c600763ec987a96ce98a47ad95ee18 Gerrit-Change-Number: 12776 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 04:11:29 +0000 Gerrit-HasComments: Yes
