Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12776 )
Change subject: [util] separate generalized CacheMetrics ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/12776/2/src/kudu/util/file_cache.cc@465 PS2, Line 465: unique_ptr<BlockCacheMetrics> metrics(new BlockCacheMetrics(entity)); > Not your fault, but this change highlights that the metrics used for FileCa I'm not sure I follow, in the case before, doesn't this still instantiate one CacheMetrics per cache? -- To view, visit http://gerrit.cloudera.org:8080/12776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic77b937e23c600763ec987a96ce98a47ad95ee18 Gerrit-Change-Number: 12776 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 05:36:59 +0000 Gerrit-HasComments: Yes
