ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 2: (3 comments) > (2 comments) http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt@162 PS1, Line 162: # compiler flags for different build types (run 'cmake -DCMAKE_BUILD_TYPE=<type> .') > Why is this necessary? Please add a comment. This variable is required by memkind head file. Moved it to memkind part http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt@452 PS1, Line 452: return() > Given that NOT NUMA_LIB_PATH on L1167 yields a fatal error, this effectivel Fixed http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt@1171 PS1, Line 1171: find_package(CURL REQUIRED) > With only a shared library, does this mean the exported C++ client library During the compilation, some library will depends on libnuma.so instead of linuma.a, like file-cache-test. So I export a shared library. -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 2 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 06:37:21 +0000 Gerrit-HasComments: Yes
