Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13188/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/2/CMakeLists.txt@1165 PS2, Line 1165: # STATIC_LIB "${NUMA_STATIC_LIB}" > During the compilation, some library will depends on libnuma.so instead of No, we absolutely need to have a static library for our RELEASE builds, so that the Kudu binaries have no external dependencies. There are some exceptions, but only for commonly installed libraries with good ABI compatibility, like openssl and libstdc++. I don't think libnuma meets that criteria. http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc@54 PS1, Line 54: DEFINE_bool(nvm_cache_force_single_shard, false, : "Override all cache implementations to use just one shard"); : TAG_FLAG(nvm_cache_force_single_shard, hidden); : > This is not for tests only. I add this flag to test case as 'cache_force_si Not sure I understand. The comment on L54 (and the 'hidden' tag) suggest that the gflag is only for testing. Are you saying it's also for production? If so, why? What Alexey is asking is if you can reuse the existing cache_force_single_shard flag instead of defining a new one. Would that be possible? -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 3 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2019 00:58:20 +0000 Gerrit-HasComments: Yes
