ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/1/CMakeLists.txt@1166 PS1, Line 1166: SHARED_LIB "${NUMA_SHARED_LIB}") > Could you answer this question, possibly also in the commit message? libnuma is required by memkind library. I've added it as a thirdparty library. http://gerrit.cloudera.org:8080/#/c/13188/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/2/CMakeLists.txt@1165 PS2, Line 1165: # STATIC_LIB "${NUMA_STATIC_LIB}" > Why is this commented out? During the compilation, some library will depends on libnuma.so instead of linuma.a, like file-cache-test. So I only export a shared library. This line will be deleted if it's ok http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc@54 PS1, Line 54: DEFINE_bool(nvm_cache_force_single_shard, false, : "Override all cache implementations to use just one shard"); : TAG_FLAG(nvm_cache_force_single_shard, hidden); : > According to the comment, this is targeted for tests only. If so, why not This is not for tests only. I add this flag to test case as 'cache_force_single_shard' -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 3 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2019 00:47:06 +0000 Gerrit-HasComments: Yes
