ye yuqiang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13188 )

Change subject: replace nvml with memkind
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13188/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/13188/2/thirdparty/build-definitions.sh@767
PS2, Line 767:   rsync -av --delete $MEMKIND_SOURCE/ .
> If you can identify the particular upstream patch (or patches) that fixed t
thanks for your advice. yes, missing omp.h is caused by building with clang. 
But -fsantize=thread does not work for both gcc and clang here. We may find out 
the patch from memkind upstream.



--
To view, visit http://gerrit.cloudera.org:8080/13188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5
Gerrit-Change-Number: 13188
Gerrit-PatchSet: 4
Gerrit-Owner: ye yuqiang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: ye yuqiang <[email protected]>
Gerrit-Comment-Date: Sat, 18 May 2019 00:57:02 +0000
Gerrit-HasComments: Yes

Reply via email to