Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14503 )
Change subject: KUDU-2980: fix ORDERED scans when key columns are misordered in projection ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc@6439 PS4, Line 6439: num_cols_to_project > I don't think so. I meant 'break' (it was a typo), and I assume the answer is that it doesn't break if running the test with empty projections :) http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc@6491 PS4, Line 6491: // Use a fault tolerant scan half the time. : if (rng.OneIn(2)) { : ASSERT_OK(scanner->SetFaultTolerant()); : } > Not sure I understand. Are you suggesting parameterizing the test itself on The difference is that with explicitly parameterized test, it would be easier to understand whether it happened on a FT or non-FT scan, if the test fails. That might help with debugging and troubleshooting. -- To view, visit http://gerrit.cloudera.org:8080/14503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb213f466c7d01b6953a863d8aa53a34b5ac8893 Gerrit-Change-Number: 14503 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 18:20:00 +0000 Gerrit-HasComments: Yes
