Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14503 )
Change subject: KUDU-2980: fix ORDERED scans when key columns are misordered in projection ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc@6491 PS4, Line 6491: if (rng.OneIn(2)) { : ASSERT_OK(scanner->SetFaultTolerant()); : } : > The difference is that with explicitly parameterized test, it would be easi Sort of agree, but for tests like these we've also been happy with the logged RNG seed (from SeedRandom). Given that the test is single-threaded, reusing the RNG seed should yield a similar scan every time. Barring that, I'd rather log the NewScanRequestPB in the test output as the basis for determinism, but unfortunately I haven't found a good way to extract that, either from the RPC call or from the KuduScanner itself. -- To view, visit http://gerrit.cloudera.org:8080/14503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb213f466c7d01b6953a863d8aa53a34b5ac8893 Gerrit-Change-Number: 14503 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 18:36:19 +0000 Gerrit-HasComments: Yes
