Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14503 )
Change subject: KUDU-2980: fix ORDERED scans when key columns are misordered in projection ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc@6491 PS4, Line 6491: if (rng.OneIn(2)) { : ASSERT_OK(scanner->SetFaultTolerant()); : } : > Maybe, just add a log line right here then: Yeah but that's not enough to repro the (hypothetical) test failure: you'd need to know the entirety of the NewScanRequestPB (i.e. projection and predicates), and possibly the PK values of the rows inserted. Only the PRNG seed will give you enough information. I guess what I'm saying is that I don't find it terribly interesting to focus on the FT vs. non-FT aspect of the test; I think it's more useful to consider all of its knobs holistically. -- To view, visit http://gerrit.cloudera.org:8080/14503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb213f466c7d01b6953a863d8aa53a34b5ac8893 Gerrit-Change-Number: 14503 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 20:09:10 +0000 Gerrit-HasComments: Yes
