Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14503 )
Change subject: KUDU-2980: fix ORDERED scans when key columns are misordered in projection ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14503/4/src/kudu/client/client-test.cc@6491 PS4, Line 6491: // Use a fault tolerant scan half the time. : if (rng.OneIn(2)) { : ASSERT_OK(scanner->SetFaultTolerant()); : } > Sort of agree, but for tests like these we've also been happy with the logg Maybe, just add a log line right here then: if (rng.OneIn(2)) { ASSERT_OK(scanner->SetFaultTolerant()); LOG_INFO("running fault-tolerant scan"); } else { LOG_INFO("running non-fault-tolerant scan"); } ? -- To view, visit http://gerrit.cloudera.org:8080/14503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb213f466c7d01b6953a863d8aa53a34b5ac8893 Gerrit-Change-Number: 14503 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 20:01:59 +0000 Gerrit-HasComments: Yes
