Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14479 )
Change subject: log: separate out allocation logic ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14479/1/src/kudu/consensus/log.h File src/kudu/consensus/log.h: http://gerrit.cloudera.org:8080/#/c/14479/1/src/kudu/consensus/log.h@80 PS1, Line 80: FsManager* fs_manager; > Would be nice to take the opportunity to doc new functions (at least public Done http://gerrit.cloudera.org:8080/#/c/14479/1/src/kudu/consensus/log.h@132 PS1, Line 132: // Shuts down the allocator threadpool. Note that this _doesn't_ close the > This backpointer makes the code quite hard to read as you have to go back a This backpointer wasn't really needed for Sync() as you've described. Updated to use function calls, per an offline discussion. http://gerrit.cloudera.org:8080/#/c/14479/1/src/kudu/consensus/log.h@349 PS1, Line 349: // [302-???] <open> (counts as 0MB) > Doc? Done -- To view, visit http://gerrit.cloudera.org:8080/14479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08be4dbdd8e98b02278de76273e931c314b08161 Gerrit-Change-Number: 14479 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 02 Nov 2019 02:12:00 +0000 Gerrit-HasComments: Yes
