Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14479 )
Change subject: log: separate out allocation logic ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.h File src/kudu/consensus/log.h: http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.h@103 PS8, Line 103: SegmentAllocator(const LogOptions* opts, > Doc this, especially the functors. Done http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@27 PS8, Line 27: #include <boost/bind.hpp> : #include <boost/function.hpp> > Can we use std bind/function for this? Done http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@569 PS8, Line 569: Status SegmentAllocator::AsyncAllocateSegmentUnlocked() { > Assert that allocation_lock_ is held? Done http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@999 PS8, Line 999: if (ctx_.hooks) { > Could we push the hooks into the SegmentAllocator? Would it be OK to call P Not as clean since WriteEntryBatch isn't a function of the SegmentAllocator, but it's mostly there. Might be able to push WriteEntryBatch into SegmentAllocator, but I think it begins blurring the interface a bit. -- To view, visit http://gerrit.cloudera.org:8080/14479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08be4dbdd8e98b02278de76273e931c314b08161 Gerrit-Change-Number: 14479 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 09 Nov 2019 03:29:38 +0000 Gerrit-HasComments: Yes
