Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14479 )
Change subject: log: separate out allocation logic ...................................................................... Patch Set 8: (5 comments) Looks like an improvement, though I think it'll be clearer once the code has had a chance to settle. http://gerrit.cloudera.org:8080/#/c/14479/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14479/8//COMMIT_MSG@42 PS8, Line 42: There are no functional changes in this patch. That seems unlikely given the nature of the refactoring. http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.h File src/kudu/consensus/log.h: http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.h@103 PS8, Line 103: SegmentAllocator(const LogOptions* opts, Doc this, especially the functors. http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@27 PS8, Line 27: #include <boost/bind.hpp> : #include <boost/function.hpp> Can we use std bind/function for this? http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@569 PS8, Line 569: Status SegmentAllocator::AsyncAllocateSegmentUnlocked() { Assert that allocation_lock_ is held? http://gerrit.cloudera.org:8080/#/c/14479/8/src/kudu/consensus/log.cc@999 PS8, Line 999: if (ctx_.hooks) { Could we push the hooks into the SegmentAllocator? Would it be OK to call PreClose() and PostClose() in CloseCurrentSegment()? And PostAppend() in WriteEntryBatch()? -- To view, visit http://gerrit.cloudera.org:8080/14479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08be4dbdd8e98b02278de76273e931c314b08161 Gerrit-Change-Number: 14479 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 08 Nov 2019 23:59:15 +0000 Gerrit-HasComments: Yes
