Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 )
Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime ...................................................................... Patch Set 1: (1 comment) > (1 comment) I think we can remove libnvm_cache, and that solves the problem of compilation at macOS. I put together a micro-patch for that (apply on top of this patch): https://gist.github.com/alexeyserbin/04f182dbc91b34e950dcaf263f28eb7c http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/nvm_cache.cc@695 PS1, Line 695: nit: shifted too far on the right? -- To view, visit http://gerrit.cloudera.org:8080/14620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f474196aa98b5fa6e5966b9a3aea9a7e466805c Gerrit-Change-Number: 14620 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ye yuqiang <yuqiang...@intel.com> Gerrit-Comment-Date: Sun, 03 Nov 2019 08:00:31 +0000 Gerrit-HasComments: Yes
