Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 )
Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime ...................................................................... Patch Set 2: (1 comment) > > Thanks for doing this, but I'd prefer to link nvm_cache into macOS > > and rely on the runtime check to gate the feature. That way we > > don't need the runtime linking functionality AND a bunch of > > Linux-specific #ifdefs. > > I mean we could get rid of libnvm_cache on both Linux and macOS. The patch I > posted is supposed to be applied on top of PS1 of this (i.e. your) patch. > That way we could get rid of the two things you mentioned and also get rid of > an extra library. > > What's the reason to have a separate kudu_nvm library? Maybe I'm missing > something, but I don't see why not to remove it once the code for both Linux > and macOS is unified and uses dlopen/dlsym to find corresponding functions. Ah, I misunderstood; I thought you meant "removing libnvm_cache _from the macOS build_", not "merge it back into kudu_util". I can definitely do that, and I agree it's net simpler. http://gerrit.cloudera.org:8080/#/c/14620/2/src/kudu/cfile/block_cache.cc File src/kudu/cfile/block_cache.cc: http://gerrit.cloudera.org:8080/#/c/14620/2/src/kudu/cfile/block_cache.cc@59 PS2, Line 59: otherwise Kudu will crash. > Is this still true? Yes: if you specify --block_cache_type=NVM and you have an old (or missing) memkind, Kudu will crash. The "forgiving" behavior is only there for unit tests, so that we can skip them if there's no memkind. -- To view, visit http://gerrit.cloudera.org:8080/14620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f474196aa98b5fa6e5966b9a3aea9a7e466805c Gerrit-Change-Number: 14620 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ye yuqiang <yuqiang...@intel.com> Gerrit-Comment-Date: Tue, 05 Nov 2019 08:33:43 +0000 Gerrit-HasComments: Yes
