Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 )
Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime ...................................................................... Patch Set 2: (3 comments) > I think we can remove libnvm_cache, and that solves the problem of > compilation at macOS. I put together a micro-patch for that (apply on top of > this patch): > https://gist.github.com/alexeyserbin/04f182dbc91b34e950dcaf263f28eb7c Thanks for doing this, but I'd prefer to link nvm_cache into macOS and rely on the runtime check to gate the feature. That way we don't need the runtime linking functionality AND a bunch of Linux-specific #ifdefs. http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: PS1: > I guess this breaks build on macOS, but I haven't figured yet why: I think it's because nvm_cache needs to depend on kudu_util, which it doesn't currently. http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/nvm_cache.cc@138 PS1, Line 138: > Maybe, use RTLD_NOW instead to detect possible issues with other symbols re Sure. FWIW I tested with libnuma missing and the error was surfaced here regardless of whether RTLD_LAZY or RTLD_NOW was used. But if libnuma is missing symbols, then I imagine RTLD_NOW will tell us. http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/nvm_cache.cc@695 PS1, Line 695: le->kv_data = > nit: shifted too far on the right? Done -- To view, visit http://gerrit.cloudera.org:8080/14620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f474196aa98b5fa6e5966b9a3aea9a7e466805c Gerrit-Change-Number: 14620 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ye yuqiang <yuqiang...@intel.com> Gerrit-Comment-Date: Sun, 03 Nov 2019 21:43:55 +0000 Gerrit-HasComments: Yes
