Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 )
Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14620/2/src/kudu/cfile/block_cache.cc File src/kudu/cfile/block_cache.cc: http://gerrit.cloudera.org:8080/#/c/14620/2/src/kudu/cfile/block_cache.cc@59 PS2, Line 59: otherwise Kudu will crash. Is this still true? http://gerrit.cloudera.org:8080/#/c/14620/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: PS1: > I think it's because nvm_cache needs to depend on kudu_util, which it doesn Yep, that's was the reason as I understand -- this code became dependent on the bunch of symbols defined in cache.cc -- To view, visit http://gerrit.cloudera.org:8080/14620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f474196aa98b5fa6e5966b9a3aea9a7e466805c Gerrit-Change-Number: 14620 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ye yuqiang <yuqiang...@intel.com> Gerrit-Comment-Date: Mon, 04 Nov 2019 17:40:18 +0000 Gerrit-HasComments: Yes
