Hello Alexey Serbin, Anonymous Coward (314),
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/17127
to review the following change.
Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run
......................................................................
KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run
In testing an in-flight patch[1], it was found that our current handling of
errors when participant registration hasn't completed can lead to
incorrect behavior: the path in which we handle NOT_FOUND errors while
committing expects that such errors only occur if the tablet has been
deleted, and we currently proceed with the commit. The incorrect
assumption here was that NOT_FOUND errors are only produced when the
tablet has been deleted, which is not the case.
This behavior will be amended in an upcoming patch[2], and we'll
actually abort the transaction on NOT_FOUND errors. Until then, this
patch adjust the behavior to return ILLEGAL_STATE instead of NOT_FOUND,
so at least the error type is consistent with the rest of the
participant op lifecycle errors.
[1] https://gerrit.cloudera.org/c/17037/
[2] https://gerrit.cloudera.org/c/17022
Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d
---
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tablet/txn_participant.h
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17127/1
--
To view, visit http://gerrit.cloudera.org:8080/17127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d
Gerrit-Change-Number: 17127
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
