Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17127 )
Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc@266 PS1, Line 266: ABORT_TXN > Right: I meant the case when either the participant is registered, but BEGI Right: I meant the case when a participant is registered, but BEGIN_TXN hasn't been issued (say, tablet server with corresponding TxnOpDispatcher has crashed), and corresponding client doesn't retry its write operation (e.g., it has timed out). I'm curious how to get out of such situation? BTW, TxnOpDispatcher clears its ops queue when receiving ABORT_TXN by responding with Status::Aborted() to all pending write requests. So, it doesn't sent ServiceUnavailable() when receiving ABORT_TXN and pending operations are present in its queue. -- To view, visit http://gerrit.cloudera.org:8080/17127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d Gerrit-Change-Number: 17127 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 06:04:35 +0000 Gerrit-HasComments: Yes