Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17127 )
Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc@266 PS1, Line 266: ABORT_TXN > Right: I meant the case when a participant is registered, but BEGIN_TXN has Ah great question. In that case, I think the correct course of action would be to treat the non-existent transaction on the participant as OK, since the end result is still that the transaction doesn't exist once the ABORT_TXN returns, and I can update this patch and my following to reflect that. Then, the question is what happens if the write is retried after that happens, and the answer there is that the new dispatcher's call to RegisterParticipant would fail. -- To view, visit http://gerrit.cloudera.org:8080/17127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d Gerrit-Change-Number: 17127 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 20:02:43 +0000 Gerrit-HasComments: Yes
