Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17127 )
Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc@266 PS1, Line 266: ABORT_TXN > Ah great question. In that case, I think the correct course of action would Thanks! This sounds like a reasonable plan, indeed. I guess we can keep this patch as is, and address the issue in a separate patch. Whatever you think is best choice here. Exactly: if the write request is retried and TxnOpDispatcher tries to register a participant and issue BEGIN_TXN for the participant again, it will fail at registering the participant. Then TxnOpDispatcher will respond with appropriate error back to client, so the client will know that its write failed. -- To view, visit http://gerrit.cloudera.org:8080/17127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d Gerrit-Change-Number: 17127 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 21:39:51 +0000 Gerrit-HasComments: Yes
