Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/kudu-tool-test.cc@817 PS1, Line 817: args.create_table_hash_bucket_factor = 10; should test both -1 and non -1 http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/table_scanner.cc@94 PS1, Line 94: factor nit: how about use 'number' instead of 'factor' to describe hash_dimension? -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 09 Jun 2022 07:06:42 +0000 Gerrit-HasComments: Yes
