Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18604/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18604/1//COMMIT_MSG@9 PS1, Line 9: copy copying http://gerrit.cloudera.org:8080/#/c/18604/1//COMMIT_MSG@11 PS1, Line 11: the The http://gerrit.cloudera.org:8080/#/c/18604/1//COMMIT_MSG@13 PS1, Line 13: copy copying http://gerrit.cloudera.org:8080/#/c/18604/1//COMMIT_MSG@16 PS1, Line 16: Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 nit: add an empty line to separate the Change-Id from the commit description http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/table_scanner.cc@95 PS1, Line 95: The hash bucket factor of the destination table What about multiple hash dimensions in case of multi-level partitioning (https://kudu.apache.org/docs/schema_design.html#multilevel-partitioning)? See https://kudu.apache.org/docs/schema_design.html#hash-hash-partitioning-example for an example. http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18604/1/src/kudu/tools/tool_action_table.cc@136 PS1, Line 136: FLAGS_create_table_hash_bucket_factor The declaration should use the name of the flag, i.e. 'create_table_hash_bucket_factor' in this case. FLAGS_xxx is a way to reference to the flag in the code. -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 10 Jun 2022 15:00:18 +0000 Gerrit-HasComments: Yes
