Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18604/4/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/4/src/kudu/tools/table_scanner.cc@434 PS4, Line 434: if (partition_schema.hash_schema().size() > 0) { nit: use !xxx.empty() http://gerrit.cloudera.org:8080/#/c/18604/4/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/18604/4/src/kudu/tools/tool_action_common.cc@924 PS4, Line 924: bool isNumber(const string& str) { Is there any function in src/kudu/gutil/strings/numbers.h would help? -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 17 Jun 2022 09:33:01 +0000 Gerrit-HasComments: Yes
