Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 )
Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc@1873 PS1, Line 1873: *block_size = sbuf.f_bsize; Will this change the return value of GetBlockSize() on a server? It will introduce compatibility issue, see [1], the new server could not restart normally because the filesystem_block_size_bytes in metadata loaded from disk is not equal to the new obtained value. 1. https://github.com/apache/kudu/blob/master/src/kudu/fs/dir_util.cc#L248 -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 08 Nov 2023 11:13:14 +0000 Gerrit-HasComments: Yes
