Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 )
Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/20680/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20680/3//COMMIT_MSG@13 PS3, Line 13: it expects the file on disk size is 64K, Where do you see this? Could you be more specific what exact code relies that that assumption? http://gerrit.cloudera.org:8080/#/c/20680/3//COMMIT_MSG@14 PS3, Line 14: Many unit tests run failed : in these systems because of the st_blksize is not equal to the : real filesystem block size. Please provide the list of those failed tests in the description. Thank you! http://gerrit.cloudera.org:8080/#/c/20680/3//COMMIT_MSG@16 PS3, Line 16: Therefore, it is better to use f_bsize : (file system block size) as Kudu's block size. I'm not sure I understand the 'why' part here because I don't see proper analysis performed, or I don't see that articulated in this description. What if this change breaks other invariants in the code for a particular OS/FS combination or makes it incompatible with prior Kudu versions? http://gerrit.cloudera.org:8080/#/c/20680/3//COMMIT_MSG@21 PS3, Line 21: control whether or not enable this feature Why this should be presented as a feature? If that's a feature, what benefits does it bring then? -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 17:43:29 +0000 Gerrit-HasComments: Yes
