Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 )
Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/20680/1/src/kudu/util/env_posix.cc@1873 PS1, Line 1873: *block_size = sbuf.f_bsize; > It will not. In most systems, f_bsize is equal to st_blksize. In this case, Where will cause the Kudu could not run normally, could you please point out the code? Keep the compatibility is very important in the community, some users may have run Kudu with filesystem_block_size_bytes=st_blksize already. -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Mon, 13 Nov 2023 06:34:55 +0000 Gerrit-HasComments: Yes
