Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20680 to look at the new patch set (#3). Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize Currently, Kudu uses st_blksize to decide Kudu block size. But st_blksize is preferred I/O block size, not the real filesystem block size. In some systems, st_blksize is 64K, and at the same time the file system block size is 4K. Kudu writes 64 bytes data into this file system, it expects the file on disk size is 64K, but actually, it's on disk size is 4K. Many unit tests run failed in these systems because of the st_blksize is not equal to the real filesystem block size. Therefore, it is better to use f_bsize (file system block size) as Kudu's block size. To be compitable with case in which Kudu has already ran on a system where f_bsize is not equal to st_blksize, --enable_use_f_bsize is used to control whether or not enable this feature. Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 --- M src/kudu/fs/log_block_manager-test.cc M src/kudu/util/env_posix.cc 2 files changed, 30 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/20680/3 -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>