Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 )
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG@28 PS3, Line 28: 3 According to the test result below, isn't it better when --rpc_listen_socket_stats_every_log2=5? http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc@1908 PS3, Line 1908: UnixSocket UnixSocket will not be tested? -- To view, visit http://gerrit.cloudera.org:8080/20908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99 Gerrit-Change-Number: 20908 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 24 Jan 2024 14:41:31 +0000 Gerrit-HasComments: Yes