Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 )
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG@28 PS3, Line 28: 3 > I guess the rationale behind that would be 32 connections might be too in-f Yes, Abhishek is correct. And wth --rpc_listen_socket_stats_every_log2=10 it's even less extra latency added (i.e. sampling every 1024 accepted connections), of course :) However, the idea was to find a value that would allow for having meaningful data for the new metric, while not adding too much latency. After some consideration, I decided to set the default value of the new flag to 3. Setting it to 5 would mean the sampling might give us values with deltas up to of 32 from the actual queue length, and I thought that deviation was too high. Of course, if there was some chronic issue with getting to many incoming connections requests, it would be possible to spot that the RX queue had been at capacity even with such low sampling frequency, but the idea was to provide some meaningful metric for non-pathological cases as well. However, I can change this if you feel strongly about this. http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc@1908 PS3, Line 1908: UnixSocket > UnixSocket will not be tested? Ah, indeed -- the idea was to skip testing Unix sockets, right. I corrected this. Or you actually meant to enable this test for Unix sockets as well? -- To view, visit http://gerrit.cloudera.org:8080/20908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99 Gerrit-Change-Number: 20908 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 25 Jan 2024 02:23:08 +0000 Gerrit-HasComments: Yes
