Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 )
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Looks good to me. Let's get Yingchun's comments addressed. http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG@28 PS3, Line 28: 3 > According to the test result below, isn't it better when --rpc_listen_socke I guess the rationale behind that would be 32 connections might be too in-frequent to collect the metrics. -- To view, visit http://gerrit.cloudera.org:8080/20908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99 Gerrit-Change-Number: 20908 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 24 Jan 2024 22:11:10 +0000 Gerrit-HasComments: Yes