Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 )
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20908/3//COMMIT_MSG@28 PS3, Line 28: 3 > Yes, Abhishek is correct. I got it. 3 is OK to me. http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/20908/3/src/kudu/rpc/rpc-test.cc@1908 PS3, Line 1908: > Ah, indeed -- the idea was to skip testing Unix sockets, right. I correcte Remove ”getaddrinfo“ is OK to me. -- To view, visit http://gerrit.cloudera.org:8080/20908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99 Gerrit-Change-Number: 20908 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 25 Jan 2024 06:21:22 +0000 Gerrit-HasComments: Yes
