Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24710 )

Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24710/5/thirdparty/vars.sh
File thirdparty/vars.sh:

PS5:
> Perhaps, you meant ANY_OS_VERSION?
The ANY_OS_VERSION flags feels a bit wrong. It should be linux-any or linux, 
not ubuntu-any for prometheus.
I think If you would name it to something like ANY_LINUX_DISTRO and change the 
behaviour a bit, it would be much more understandable: A Package linked 
statically, so only have a minimal linux kernel requirement, but can be shared 
across versions and distros.


http://gerrit.cloudera.org:8080/#/c/24710/6/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/24710/6/thirdparty/vars.sh@118
PS6, Line 118: # * <comp>_ANY_OS_VERSION
             : #   Set to 1 to indicate that pre-built artifacts for this 
component fit
             : #   any version of the OS that the artifacts are built for.
             : #
             : # * <comp>_ANY_TOOLCHAIN
             : #   Set to 1 to indicate that pre-built artifacts for this 
component fit
             : #   any toolchain (e.g., clang-17.0, gcc-13.1, etc.)
also mention dependency between this 2. (ANY_ARCH=1  => ANY_TOOLCHAIN=1)



--
To view, visit http://gerrit.cloudera.org:8080/24710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7
Gerrit-Change-Number: 24710
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 20:32:09 +0000
Gerrit-HasComments: Yes

Reply via email to