Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24710 )
Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/24710/5/thirdparty/vars.sh File thirdparty/vars.sh: PS5: > The ANY_OS_VERSION flags feels a bit wrong. It should be linux-any or linux ANY_LINUX_DISTRO isn't viable for components that aren't a set of statically compiled binaries, i.e. for the rest of components that come as with binary artifacts. As one can see, the problem stems at least from difference of glibc/libc versions that different distributions come with. There are also issues with locations and naming of system libraries, their versioned/non-versioned symbols, etc. While ANY_OS_VERSION isn't optimal for Prometheus case, it still allows for reduction of space consumed by pre-built archives. I think we can work on implementing ANY_LINUX_DISTRO or similar provision in follow-up changelist. I don't want to add it into this changelist because it's a narrow provision (fits only Prometheus as of now), but it's still logically independent while not exactly straightforward with the current naming of 3rd-party pre-built archives, and requires more holistic approach than the variables introduced here. http://gerrit.cloudera.org:8080/#/c/24710/6/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/24710/6/thirdparty/vars.sh@118 PS6, Line 118: # * <comp>_ANY_OS_VERSION : # Set to 1 to indicate that pre-built artifacts for this component fit : # any version of the OS that the artifacts are built for. : # : # * <comp>_ANY_TOOLCHAIN : # Set to 1 to indicate that pre-built artifacts for this component fit : # any toolchain (e.g., clang-17.0, gcc-13.1, etc.) > also mention dependency between this 2. (ANY_ARCH=1 => ANY_TOOLCHAIN=1) Done -- To view, visit http://gerrit.cloudera.org:8080/24710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7 Gerrit-Change-Number: 24710 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 02:37:15 +0000 Gerrit-HasComments: Yes
