Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24710 )

Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@21
PS7, Line 21:
postgres_jdbc space hogs?


http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@22
PS7, Line 22: 8247f
build


http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@22
PS7, Line 22: Change-I
rest of the


http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@24
PS7, Line 24:
even though?


http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh
File thirdparty/prebuilt-utils.sh:

http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@192
PS1, Line 192: $(echo $component | tr '[:lower:]' '[:upper:]' | tr '-' '_')
> Where else did you see those?  I couldn't find anything else in thirdparty-
https://github.com/apache/kudu/blob/741f8ee044b9985780da4569a093f70682849df6/thirdparty/prebuilt-utils.sh#L159

https://github.com/apache/kudu/blob/741f8ee044b9985780da4569a093f70682849df6/thirdparty/fetch-utils.sh#L186

I see you have already taken care of those.
Thanks!


http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@199
PS1, Line 199: -a
> '&&' require switching to '[[]]' operations, and I'm not going to extend th
Consider switching to '&&' for new additions made under  this changelist, if 
not for existing occurrences.



--
To view, visit http://gerrit.cloudera.org:8080/24710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7
Gerrit-Change-Number: 24710
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 11:24:35 +0000
Gerrit-HasComments: Yes

Reply via email to