Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24710 )
Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@21 PS7, Line 21: postgres_jdbcspace hogs > postgres_jdbc space hogs? Done http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@22 PS7, Line 22: built > build Done http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@22 PS7, Line 22: rest of > rest of the Done http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@24 PS7, Line 24: even if > even though? Done http://gerrit.cloudera.org:8080/#/c/24710/7//COMMIT_MSG@26 PS7, Line 26: ut it doesn't seem to modify the headers depending on the architecture, : OS or toolchain > With that, should jwt-cpp also moved to common just like trace-viewer, gcov Maybe, but I'm not doing so in this changelist. The context of this changelist is about reducing the duplication in pre-built artifacts, not about about re-shuffling the components across groups. http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@199 PS1, Line 199: _v > Consider switching to '&&' for new additions made under this changelist, i No, I'm not going to do so. And I already explained the reasoning. -- To view, visit http://gerrit.cloudera.org:8080/24710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7 Gerrit-Change-Number: 24710 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 14:54:04 +0000 Gerrit-HasComments: Yes
