----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90610 -----------------------------------------------------------
Thanks for adding the hook! There is one more code path that a docker container can be launched, which is in launchExecutorProcess. Can you add the hook call in that path as well? - Timothy Chen On July 5, 2015, 9:14 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36185/ > ----------------------------------------------------------- > > (Updated July 5, 2015, 9:14 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2588 > https://issues.apache.org/jira/browse/MESOS-2588 > > > Repository: mesos > > > Description > ------- > > Create pre-launch hook before a docker container launches in slave. > > > Diffs > ----- > > include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f > src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc > src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf > src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba > > Diff: https://reviews.apache.org/r/36185/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
