> On July 10, 2015, 11:20 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, line 3114 > > <https://reviews.apache.org/r/36185/diff/3/?file=1002346#file1002346line3114> > > > > What you suggested sounds fine. > > I think we need to comment on the top of the test what this tests and > > what is it expecting to see. It wasn't too obvious when I read this.
Sorry for the not clear test case before, I updated it now. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review91367 ----------------------------------------------------------- On July 11, 2015, 8:45 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36185/ > ----------------------------------------------------------- > > (Updated July 11, 2015, 8:45 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2588 > https://issues.apache.org/jira/browse/MESOS-2588 > > > Repository: mesos > > > Description > ------- > > Create pre-launch hook before a docker container launches in slave. > > > Diffs > ----- > > include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f > src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab > src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc > src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf > src/slave/containerizer/docker.hpp 9a7a951a72390b38f5dda3a3d50c4b35a6c784fd > src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f > src/tests/docker_containerizer_tests.cpp > a3da786c1b733e9dd4abf1d02d5dae051393d921 > src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db > src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 > > Diff: https://reviews.apache.org/r/36185/diff/ > > > Testing > ------- > > # Add a new unit test > "DockerContainerizerTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook" > make check -j8 GTEST_FILTER=-"*" > sudo ./bin/mesos-tests.sh --verbose > --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook > > > Thanks, > > haosdent huang > >
