----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119399 -----------------------------------------------------------
include/mesos/mesos.proto (line 598) <https://reviews.apache.org/r/43616/#comment180749> s/Labels/One label? I think that here we should use `one label` but not `labels`, becauase this can only happen if one label include duplicate key-value pairs. - Guangya Liu On 二月 16, 2016, 7:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43616/ > ----------------------------------------------------------- > > (Updated 二月 16, 2016, 7:15 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The implementation of the equality operator for `Labels` is buggy for labels > that contain duplicates. We might want to revisit fixing the implementation of > that operator (which might be expensive; MESOS-4445), but in the short-term we > should document that duplicates should not be specified. > > > Diffs > ----- > > include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 > include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a > > Diff: https://reviews.apache.org/r/43616/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
