> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > <https://reviews.apache.org/r/43616/diff/1/?file=1251896#file1251896line598> > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > > this can only happen if one label include duplicate key-value pairs.
Among all the key-value pairs in a `Labels`, no two pairs should be the same. So I think the current text expresses that better than talking about an individual label. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119399 ----------------------------------------------------------- On Feb. 16, 2016, 7:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43616/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 7:15 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The implementation of the equality operator for `Labels` is buggy for labels > that contain duplicates. We might want to revisit fixing the implementation of > that operator (which might be expensive; MESOS-4445), but in the short-term we > should document that duplicates should not be specified. > > > Diffs > ----- > > include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 > include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a > > Diff: https://reviews.apache.org/r/43616/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
