> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > <https://reviews.apache.org/r/43616/diff/1/?file=1251896#file1251896line598> > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > > this can only happen if one label include duplicate key-value pairs. > > Neil Conway wrote: > Among all the key-value pairs in a `Labels`, no two pairs should be the > same. So I think the current text expresses that better than talking about an > individual label.
May be we need to be more accurate, if `Labels should not contain duplicate key-value pairs`, then how can mesos define same labels? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119399 ----------------------------------------------------------- On 二月 17, 2016, 6:44 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43616/ > ----------------------------------------------------------- > > (Updated 二月 17, 2016, 6:44 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The implementation of the equality operator for `Labels` is buggy for labels > that contain duplicates. We might want to revisit fixing the implementation of > that operator (which might be expensive; MESOS-4445), but in the short-term we > should document that duplicates should not be specified. > > > Diffs > ----- > > include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 > include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 > > Diff: https://reviews.apache.org/r/43616/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
