> On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2385 > > <https://reviews.apache.org/r/43879/diff/4/?file=1267401#file1267401line2385> > > > > Why a anonymous namespace? `static` should be fine.
In C `static` has more usages than just denoting internal linkage and the meaning needs to be inferred from the context, while C++ has anonymous namespaces just for that; so I would say it is rather "just anonymous namespace should be fine" than the other way around. Switched to `static` here anyway. > On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2395 > > <https://reviews.apache.org/r/43879/diff/4/?file=1267401#file1267401line2395> > > > > What are you going to do for this comments? or just a notes? Converted to `NOTE`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120507 ----------------------------------------------------------- On Feb. 24, 2016, 2:25 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43879/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 2:25 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for number of allocations made. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43879/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >