----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123662 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/spec.proto (line 40) <https://reviews.apache.org/r/44549/#comment185891> Why are the position identifiers not sequential ? src/slave/containerizer/mesos/isolators/network/cni/spec.proto (line 42) <https://reviews.apache.org/r/44549/#comment185893> You will need to store the path of the network config as well, since during the isolate/prepare phase you will need to re-read the whole config (since it might have plugin specific parameters). src/slave/containerizer/mesos/isolators/network/cni/spec.proto (lines 43 - 46) <https://reviews.apache.org/r/44549/#comment185892> Same question on positional identifiers ? Should start with 1 ? - Avinash sridharan On March 15, 2016, 2:05 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44549/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:05 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkConfig". > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44549/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
