> On March 15, 2016, 11:28 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, lines 45-46 > > <https://reviews.apache.org/r/44549/diff/3/?file=1299735#file1299735line45> > > > > The isolator doesn't actually need the IPAM or the DNS information. > > This information would be used only by the plugin and the isolator doesn't > > have to do anything with them. So don't think keeping these fields in the > > `NetworkConfig` would serve any purpose? > > > > We do need to store the DNS and ROUTES returned in the `RESULT` of > > invoking the plugin, but thoses pieces should probably go in a separate > > protobuf (NetworkResult maybe) ?
As we discussed in the sync up meeting, it should be OK to keep IPAM and DNS in `NetworkConfig`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123664 ----------------------------------------------------------- On March 15, 2016, 10:05 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44549/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 10:05 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkConfig". > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44549/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
