----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123972 -----------------------------------------------------------
Fix it, then Ship it! src/CMakeLists.txt (line 279) <https://reviews.apache.org/r/44549/#comment186315> I don't think we put headers here. src/slave/containerizer/mesos/isolators/network/cni/spec.cpp (line 37) <https://reviews.apache.org/r/44549/#comment186316> indentation here should be 2 as it's a statement. src/slave/containerizer/mesos/isolators/network/cni/spec.cpp (line 38) <https://reviews.apache.org/r/44549/#comment186317> We typically insert a new line above if the preceding statement is a multiple line statement. - Jie Yu On March 16, 2016, 2:09 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44549/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 2:09 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkConfig". > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44549/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
